outbound/ssh: add cipher, MAC, and key exchange configuration#4066
Closed
rojer wants to merge 54 commits intoSagerNet:testingfrom
Closed
outbound/ssh: add cipher, MAC, and key exchange configuration#4066rojer wants to merge 54 commits intoSagerNet:testingfrom
rojer wants to merge 54 commits intoSagerNet:testingfrom
Conversation
nekohasekai
force-pushed
the
testing
branch
3 times, most recently
from
99e1ffe to
8130928
Compare
`SecTrustEvaluateWithError` is serial
This reverts commit 62cb06c.
Serialize probe rounds in startProber to eliminate unbounded fan-out of fire-and-forget probe goroutines (up to 100/sec per direction), and close HTTP/3 transports via transport.Close() in addition to CloseIdleConnections.
Ability to specify client's cipher preference is useful. In particular, often `aes128-gcm` is more efficient but `chacha-poly1305` is selected instead.
Author
|
@nekohasekai this is a small change that shouldn't be controversial, any chance it can be merged before 0.14? |
nekohasekai
force-pushed
the
testing
branch
5 times, most recently
from
1b0e6c5 to
abedea4
Compare
Author
|
@nekohasekai ok, i see it's been added in 610aa94 but without validation. i think validation is important, as incorrect configuration may seem to work, but actual ciphers not to be used. |
Author
|
however, this is enough for me so i'll close this PR. leaving validation up to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability to specify client's cipher preference is useful. In particular, often
aes128-gcmis more efficient butchacha-poly1305is selected instead.